[CI][Github] Version pin packages in windows container #148319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesI spent several hours debugging failures in the server 2022 container Full diff: https://github.com/llvm/llvm-project/pull/148319.diff 1 Files Affected:
diff --git a/.github/workflows/containers/github-action-ci-windows/Dockerfile b/.github/workflows/containers/github-action-ci-windows/Dockerfile
index 59ba5c2cebf97..f829d4e900217 100644
--- a/.github/workflows/containers/github-action-ci-windows/Dockerfile
+++ b/.github/workflows/containers/github-action-ci-windows/Dockerfile
@@ -39,11 +39,13 @@ RUN regsvr32 /S "C:\BuildTools\DIA SDK\bin\amd64\msdia140.dll" & \
# install tools as described in https://llvm.org/docs/GettingStartedVS.html
# and a few more that were not documented...
-RUN choco install -y ninja git sccache
# Pin an older version of Python; the current Python 3.10 fails when
# doing "pip install" for the other dependencies, as it fails to find libxml
# while compiling some package.
-RUN choco install -y python3 --version 3.9.7
+RUN choco install -y ninja --version 1.13.1 && \
+ choco install -y git --version 2.50.1 && \
+ choco install -y sccache --version 0.10.0 && \
+ choco install -y python3 --version 3.9.7
# Testing requires psutil
RUN pip install psutil
|
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Jul 14, 2025
I spent several hours debugging failures in the server 2022 container today that turned out to be related to a new ninja release from a couple weeks ago. This patch version pins all the packages so they do not spuriously upgrade and we can control the process to waste less effort debugging changes due to version changes. Pull Request: llvm#148319
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
boomanaiden154
changed the base branch from
users/boomanaiden154/main.cigithub-version-pin-packages-in-windows-container
to
main
cmtice
reviewed
Jul 14, 2025
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Jul 14, 2025
I spent several hours debugging failures in the server 2022 container today that turned out to be related to a new ninja release from a couple weeks ago. This patch version pins all the packages so they do not spuriously upgrade and we can control the process to waste less effort debugging changes due to version changes. Pull Request: llvm#148319
cmtice
approved these changes
Jul 14, 2025
boomanaiden154
deleted the
users/boomanaiden154/cigithub-version-pin-packages-in-windows-container
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jul 14, 2025
I spent several hours debugging failures in the server 2022 container today that turned out to be related to a new ninja release from a couple weeks ago. This patch version pins all the packages so they do not spuriously upgrade and we can control the process to waste less effort debugging changes due to version changes. Reviewers: cmtice, tstellar, lnihlen Reviewed By: cmtice Pull Request: llvm/llvm-project#148319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent several hours debugging failures in the server 2022 container
today that turned out to be related to a new ninja release from a couple
weeks ago. This patch version pins all the packages so they do not
spuriously upgrade and we can control the process to waste less effort
debugging changes due to version changes.